fix: add ESM exports to support consistent CJS interop in Vite/Rolldown#95
Open
neisukee wants to merge 1 commit intocodler:masterfrom
Open
fix: add ESM exports to support consistent CJS interop in Vite/Rolldown#95neisukee wants to merge 1 commit intocodler:masterfrom
neisukee wants to merge 1 commit intocodler:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the introduction of consistent CJS interop in Vite (powered by Rolldown),
projects using
"type": "module"receivemodule.exportsas the default importinstead of
module.exports.default.This causes
react-ga4's default import to return the entire exports objectrather than the GA4 instance, breaking
ga4.initialize()and other methods.See: https://rolldown.rs/in-depth/bundling-cjs#ambiguous-default-import-from-cjs-modules
Solution
Add an ESM entry point via the
exportsfield inpackage.json,so bundlers can resolve the proper ESM version directly.
Changes
babel.config.jsto support ESM build (modules: falsewhenBABEL_ENV=esm).jsextensions to relative imports insrc/for Node.js ESM compatibilitydist/cjs/dist/esm/exports,modulefields topackage.json