Compute Worker - Fix submission files duplication#2285
Open
ihsaan-ullah wants to merge 10 commits intodevelopfrom
Open
Compute Worker - Fix submission files duplication#2285ihsaan-ullah wants to merge 10 commits intodevelopfrom
ihsaan-ullah wants to merge 10 commits intodevelopfrom
Conversation
…e submission during both ingestion and scoring
3 tasks
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR has the following updates:
.env_sampleWORKER_BUNDLE_URL_REWRITEsrc/apps/competitions/tasks.pycomputer_worker.pySubmissionStatusfor submission statuses and related updatesProgramKindfor program kind and related updatesSettingsthat gathers all env variables. This class is now used all over the code for accessing settings. NOTE: This can be further improved to convert strings to booleans so that we don't use== "true"or `== "false".programtoscoring_programstartfunction to clarify which functions will run during ingestion and during scoring, and separated submission and scoring program clearlyapp/ingested_program_run_program_directoryfunction to simplify code and logs_run_program_directoryto a new function_create_containerfor reusability and claritywatch_detailed_resultsfunction to avoid looping forevercontainer_id(undeclared) bycontainer.get("Id") in_run_container_engine_cmd`startfunction that was failing submission even if everything went well. Need to discuss this and update the codeIssues this PR resolves
A checklist for hand testing
Checklist