feat: add support for mapped types#111
Merged
pan-kot merged 1 commit intocloudscape-design:mainfrom Mar 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 96.75% 97.38% +0.62%
==========================================
Files 11 11
Lines 864 918 +54
Branches 290 294 +4
==========================================
+ Hits 836 894 +58
+ Misses 28 24 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SpyZzey
reviewed
Mar 6, 2026
Comment on lines
+151
to
+153
| type = checker.getTypeOfSymbolAtLocation(value, namespaceDeclaration!); | ||
| rawTypeNode = undefined; | ||
| description = { text: undefined, tags: [] }; |
Member
There was a problem hiding this comment.
Could you add a test that covers these lines (for when declaration is undefined/null)?
Contributor
Author
There was a problem hiding this comment.
Just pushed changes that add the missing coverage.
e5092e5 to
ddc761c
Compare
pan-kot
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: AWSUI-61054
Description of changes:
Motivation
The documenter crashes when a component interface uses a mapped type (e.g.
{ [name in IconProps.Name]?: ReactNode }), because mapped type members are synthetic symbols andgetDeclarations()returns no usable property node. This blocks replacing 140+ hand-listed properties inIconProviderProps.Iconswith a single mapped type (AWSUI-61054).Changes
tryExtractDeclarationandisOptionalSymbolhelpers totype-utils.tsfor handling synthetic symbols from mapped typesextractor.tsandobject-definition.tsto gracefully handle properties that lackPropertySignature/PropertyDeclarationnodes, falling back tochecker.getTypeOfSymbolAtLocation()and symbol flag checksRecord<K,V>, and inline mapped typesTesting
mapped-types.test.tspasses which covers property names, types, and optionality.IconProviderProps.Iconsconverted to a mapped type, and documenter output is identical to the manually listed versionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.