Replace maps and bools with atomic primitives#685
Merged
gabriel-samfira merged 2 commits intocloudbase:mainfrom Mar 20, 2026
Merged
Replace maps and bools with atomic primitives#685gabriel-samfira merged 2 commits intocloudbase:mainfrom
gabriel-samfira merged 2 commits intocloudbase:mainfrom
Conversation
This change switches from maps to sync.Map for various internal maps we used to keep track of state. This spares us from having to guard access to those maps using a mutex, hopefully eliminating potential deadlocks. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Replace the "running" bool with atomic.Bool. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Contributor
|
Thanks for the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reduces the need for mutexes by replacing maps and bools used for state tracking with sync.Map and atomic.Bool.
Fixes: #684