test(rpc-client): test_qr_securejoin_broadcast: Wait for CHATLIST_CHANGED before getting chatlist#7437
Closed
test(rpc-client): test_qr_securejoin_broadcast: Wait for CHATLIST_CHANGED before getting chatlist#7437
Conversation
…NGED before getting chatlist
iequidoo
force-pushed
the
iequidoo/test_qr_securejoin_broadcast
branch
from
c3c7553 to
2c21f54
Compare
iequidoo
commented
Nov 12, 2025
| # Start second Bob device, if it wasn't started already. | ||
| bob2.start_io() | ||
| bob2.wait_for_securejoin_joiner_success() | ||
| bob2.wait_for_event(EventType.CHATLIST_CHANGED) |
Collaborator
Author
There was a problem hiding this comment.
It's weird that this is only needed for the bob2 device, the reason is that events arrive in another order on the second device. But i'm not sure it's worth complicating the test and trying to wait for this event for the first device somehow. Maybe it's better then to fix Core and emit CHATLIST_CHANGED one more time after SecureJoin finishes
Collaborator
There was a problem hiding this comment.
Thanks for figuring out the problem!
We can probably move the call to get_broadcast() down a bit? I made an alternative PR: #7442
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7426 (comment)