TA-4530: Implement secure secret storage#323
Open
Laberion Ajvazi (LaberionAjvazi) wants to merge 10 commits intomasterfrom
Open
TA-4530: Implement secure secret storage#323Laberion Ajvazi (LaberionAjvazi) wants to merge 10 commits intomasterfrom
Laberion Ajvazi (LaberionAjvazi) wants to merge 10 commits intomasterfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Laberion Ajvazi (LaberionAjvazi)
force-pushed
the
LaberionAjvazi/ta-4530
branch
from
1996ea7 to
91829c0
Compare
… secure command - Swap archived keytar (atom/node-keytar 7.9.0) for maintained fork (@github/keytar 7.10.6, pinned version) - Add `content-cli profile secure <profile>` command to migrate existing plaintext profiles to system keychain storage - Add @aocelo and @siavash-celonis as CODEOWNERS for package.json and yarn.lock Includes-AI-Code: true Made-with: Cursor
Laberion Ajvazi (LaberionAjvazi)
force-pushed
the
LaberionAjvazi/ta-4530
branch
from
91829c0 to
210ec4b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Wrap the keytar findCredentials call in getSecrets with try-catch so that keychain errors (locked, permission denied) return undefined instead of propagating to the caller with a generic error message. Includes-AI-Code: true Made-with: Cursor
|
Laberion Ajvazi (LaberionAjvazi)
requested a review
from a team
as a code owner
Laberion Ajvazi (LaberionAjvazi)
requested review from
andyo (aocelo) and
Siavash Safaei (siavash-celonis)
andyo (aocelo)
approved these changes
Mar 17, 2026
Meris Nici (promeris)
approved these changes
Mar 18, 2026
Zgjim Haziri (ZgjimHaziri)
approved these changes
Mar 18, 2026
Buqeta (Buqeta)
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented secure secret storage using
@github/keytar(the actively maintained fork ofatom/node-keytar) with fallback to the current plain text storage for cases where storing the secrets in the system keychain fails or is not available (e.g., on Linux due to libsecret dependency).A warning will be shown to users when creating or using a profile with insecure secret storage.
Changes from the original PR #301:
keytar(atom/node-keytar v7.9.0) with@github/keytarv7.10.6 (pinned version, no caret) — same API, actively maintainedcontent-cli profile secure <profile>command to migrate existing plaintext profiles to secure keychain storage without re-creating them (addresses Meris's review comment on the closed PR)@aoceloand@siavash-celonisas CODEOWNERS forpackage.jsonandyarn.lockmaster(resolved conflicts with dependabot bumps, TA-4814, TA-4654)Summary of changes
SecureSecretStorageServiceusing@github/keytarto save/retrieveapiToken,clientSecret, andrefreshTokenundercelonis-content-cli:<profile-name>Profilemodel updated (ProfileSecrets,secretsStoredSecurelyflag);storeProfilenow async, strips secrets when saved securely;findProfileloads secrets from keychain when flaggedProfileCommandService/ProfileServiceupdated to awaitstoreProfileand persist refreshed tokens securelyprofile secure <profile>CLI command for migrating existing plaintext profiles to secure storageRelevant links
atom/node-keytar)@github/keytarChecklist