Issue 280 fix log lock with a non none dummy lock#281
Merged
Conversation
In Python 3.13, the Python's loggin.StreamHandler uses its lock without using explicitly its `acquire` and `release` methods so when the class uses the lock, it finds a `None` and it crashes. `None` was set by XStreamHandler to avoid the cost of it (because the mutual exclusion is solved by downstream code (concerns set) and the lock is not really needed). Now, we use a _DummyRLock to emulate a real reentrant lock but with zero cost as designed. Closes #280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.