fix: prevent duplicate include entries in SSH config#339
Open
hakhandelwal11 wants to merge 1 commit intomainfrom
Open
fix: prevent duplicate include entries in SSH config#339hakhandelwal11 wants to merge 1 commit intomainfrom
hakhandelwal11 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probelm:
This PR fixes an issue where config path comparisons fail in Windows environments due to differences in file path syntax. While macOS/Linux use forward slashes (/), Windows uses backward slashes (), causing mismatches in string-based comparisons.
Additionally, this change ensures that the include statement is not duplicated by correctly matching existing config paths across platforms.
Solution
Added a Windows-specific normalization step to ensure paths are converted before comparison.
Updated condition:
if strings.Contains(conf, makeIncludeBrevStr(toWindowsPath(brevConfigPath)))
This ensures that when running in a Windows environment, the config path is converted to Windows format before being used in the comparison, preventing duplicate include entries.