Configured 'skip' actions for rule 'github_action_from_unverified_creator_used' are ignored#398
Open
mbarbero wants to merge 1 commit intoboostsecurityio:mainfrom
Open
Configured 'skip' actions for rule 'github_action_from_unverified_creator_used' are ignored#398mbarbero wants to merge 1 commit intoboostsecurityio:mainfrom
mbarbero wants to merge 1 commit intoboostsecurityio:mainfrom
Conversation
…r_used The skip logic was comparing the finding's purl (repository purl) against the skip config's action purls, which never matched. Now the dependency purl is stored in the finding meta, and the skip logic checks it during filtering: - Versionless skip purl matches any version (greatest common denominator) - Versioned skip purl matches only that exact version The matching uses structural purl boundaries (@ and #) to prevent false prefix matches (e.g., @v2 won't match @v2.7.1). Signed-off-by: Mikaël Barbero <mikael.barbero@eclipse-foundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skip logic was comparing the finding's purl (repository purl) against the skip config's action purls, which never matched. Now the dependency purl is stored in the finding meta, and the skip logic checks it during filtering:
The matching uses structural purl boundaries (@ and #) to prevent false prefix matches (e.g.,
@v2won't match@v2.7.1).Fixes #397