Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for Bosch XDK110 implementation #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Some fixes for Bosch XDK110 implementation #269
Changes from all commits
ede324d6780a87424c8ee6a7569501230372a405b70870260cc29718617747efc3a29b335cc0f2778e12cad5f2b7bef3d06653b3ec2ccf8486b0f921c13aaf75d2bbbFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Check warning on line 125 in platform/freertos/btstack_run_loop_freertos.c
Make the type of this variable a pointer-to-const. The current type of "next" is "struct btstack_timer_source *".
Check warning on line 149 in platform/freertos/btstack_run_loop_freertos.c
Declare the variable "it" inside the loop.
Check warning on line 149 in platform/freertos/btstack_run_loop_freertos.c
Remove this redundant cast.
Check warning on line 150 in platform/freertos/btstack_run_loop_freertos.c
Make the type of this variable a pointer-to-const. The current type of "ts" is "struct btstack_timer_source *".
Check failure on line 134 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 135 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 136 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 150 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 151 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 155 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 157 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 160 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 167 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 171 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 172 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 178 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 179 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 181 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 188 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 189 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 197 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 327 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 559 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 621 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 627 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 640 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check failure on line 641 in src/bluetooth.h
Replace this macro by "const", "constexpr" or an "enum".
Check warning on line 424 in src/hci.c
Make the type of this parameter a pointer-to-const. The current type of "connection" is "hci_connection_t *".
Check warning on line 531 in src/hci.c
Complete the task associated to this "TODO" comment.
Check warning on line 726 in src/hci.c
Remove the commented out code.
Check warning on line 1535 in src/hci.c
Make the type of this parameter a pointer-to-const. The current type of "packet" is "unsigned char *".
Check failure on line 1535 in src/hci.c
Refactor this function to reduce its Cognitive Complexity from 72 to the 25 allowed.
Check warning on line 1937 in src/hci.c
Merge this "if" statement with the enclosing one.
Check warning on line 2009 in src/hci.c
Remove the commented out code.
Check warning on line 2019 in src/hci.c
Remove the commented out code.
Check warning on line 2035 in src/hci.c
Merge this "if" statement with the enclosing one.
Check failure on line 2181 in src/hci.c
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
Check warning on line 2233 in src/hci.c
Make the type of this variable a pointer-to-const. The current type of "features" is "unsigned char *".
Check failure on line 2482 in src/hci.c
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
Check warning on line 2703 in src/hci.c
Remove the commented out code.
Check warning on line 3316 in src/hci.c
Remove the commented out code.
Check failure on line 3813 in src/hci.c
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
Check warning on line 4286 in src/hci.c
Complete the task associated to this "TODO" comment.
Check warning on line 4893 in src/hci.c
Make the type of this parameter a pointer-to-const. The current type of "address" is "unsigned char *".
Check warning on line 4907 in src/hci.c
Make the type of this parameter a pointer-to-const. The current type of "address" is "unsigned char *".
Check warning on line 5028 in src/hci.c
Make the type of this parameter a pointer-to-const. The current type of "addr" is "unsigned char *".
Check warning on line 199 in src/hci_transport_h5.c
Make the type of this parameter a pointer-to-const. The current type of "ts" is "struct btstack_timer_source *".