Skip to content

ci: update pull request template#240

Closed
va-an wants to merge 3 commits intobitcoindevkit:masterfrom
va-an:ci/update-pr-template
Closed

ci: update pull request template#240
va-an wants to merge 3 commits intobitcoindevkit:masterfrom
va-an:ci/update-pr-template

Conversation

@va-an
Copy link
Contributor

@va-an va-an commented Feb 13, 2026

Description

We now have just pre-push after #235, let's use it in the PR template checklist.

Checklists

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21985678347

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 10.716%

Totals Coverage Status
Change from base Build 21153868360: -0.001%
Covered Lines: 268
Relevant Lines: 2501

💛 - Coveralls

@tvpeter tvpeter added this to the CLI 3.0.0 milestone Feb 26, 2026
@notmandatory notmandatory moved this to Ready to Review in BDK-CLI Mar 10, 2026
Copy link
Collaborator

@tvpeter tvpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @va-an,

Since this PR is about a single change and it cannot serve that purpose, I will be closing the PR.

Thank you.

* [ ] I've signed all my commits
* [ ] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
* [ ] I ran `cargo fmt` and `cargo clippy` before committing
* [ ] I ran `just pre-push` before committing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-push command defined in this project does not format the code; it only checks, and so it can not serve the same purpose.

@tvpeter
Copy link
Collaborator

tvpeter commented Mar 12, 2026

Hi @va-an , thank you for continuing to work on this project.

I would like to suggest that, if possible, you should be more proactive in reviewing PRs and proposing related enhancements. Also, some of these minor chores can be added to other PRs (a commit message and changelog notice in the description would be enough), or multiple chores can be combined into a single PR. This way, we can avoid having too many PRs that don't genuinely advance the project.

Thank you so much.

@tvpeter
Copy link
Collaborator

tvpeter commented Mar 12, 2026

I'll be closing this issue as indicated in the review.

Thank you.

@tvpeter tvpeter closed this Mar 12, 2026
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in BDK-CLI Mar 12, 2026
@tvpeter tvpeter removed this from the CLI 3.0.0 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants