ci: update pull request template#240
Closed
va-an wants to merge 3 commits intobitcoindevkit:masterfrom
Closed
Conversation
Pull Request Test Coverage Report for Build 21985678347Details
💛 - Coveralls |
tvpeter
reviewed
Mar 12, 2026
| * [ ] I've signed all my commits | ||
| * [ ] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md) | ||
| * [ ] I ran `cargo fmt` and `cargo clippy` before committing | ||
| * [ ] I ran `just pre-push` before committing |
Collaborator
There was a problem hiding this comment.
The pre-push command defined in this project does not format the code; it only checks, and so it can not serve the same purpose.
Collaborator
|
Hi @va-an , thank you for continuing to work on this project. I would like to suggest that, if possible, you should be more proactive in reviewing PRs and proposing related enhancements. Also, some of these minor chores can be added to other PRs (a commit message and changelog notice in the description would be enough), or multiple chores can be combined into a single PR. This way, we can avoid having too many PRs that don't genuinely advance the project. Thank you so much. |
Collaborator
|
I'll be closing this issue as indicated in the review. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We now have
just pre-pushafter #235, let's use it in the PR template checklist.Checklists
cargo fmtandcargo clippybefore committing