feat: Allow files in wheels to be installed to directories#3233
Open
Ahajha wants to merge 3 commits intobazel-contrib:mainfrom
Open
feat: Allow files in wheels to be installed to directories#3233Ahajha wants to merge 3 commits intobazel-contrib:mainfrom
Ahajha wants to merge 3 commits intobazel-contrib:mainfrom
Conversation
When specifying `data_files` in `py_wheel`, allow just the directory to be specified (with a trailing slash), in which case it will use the file's name. This avoids duplicating (potentially platform-specific) names.
Ahajha
force-pushed
the
ahajha/wheel-dir
branch
from
6477498 to
c9f1b27
Compare
Contributor
Author
|
Sorry for the long pause while this sat here, been a busy few months but I got some time to come back to this. Still need to add a few tests + update docs, but the core functionality is ready. |
Contributor
Author
|
@aignas Can I get a review on this? We've been using it internally for a while and it's working well for us. Happy to add tests/docs, etc. if you'd like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specifying
data_filesinpy_wheel, allow just the directory to be specified (with a trailing slash), in which case it will use the existing filename. This avoids duplicating (potentially platform-specific) names. Additionally, targets with multiple files can be installed as a group to a folder, with the same filename-preserving behavior.Before, this would result in the file simply not being installed, so this only changes already-broken behavior.
PR Instructions/requirements
CHANGELOG.mdas applicable