fix(sybil-resistance): remove nx option to ensure claim updates in KV#2984
Open
evshank wants to merge 1 commit intobase:masterfrom
Open
fix(sybil-resistance): remove nx option to ensure claim updates in KV#2984evshank wants to merge 1 commit intobase:masterfrom
nx option to ensure claim updates in KV#2984evshank wants to merge 1 commit intobase:masterfrom
Conversation
Problem
The kv.set() call uses { nx: true }, which prevents updating existing records. When a key already exists in KV but the current discountType is not in previousClaims, the data isn't saved — yet the API still returns a signedMessage as if the claim was successfully stored.
This creates inconsistency between KV state and API response, breaking the anti-sybil protection mechanism that prevents duplicate signature issuance.
Solution
Remove nx: true from kv.set() options to ensure the record is always updated.
Impact
Existing records properly update when a new discountType is added
Duplicate claims for the same discountType are still rejected (upstream logic unchanged)
TTL (expiry) functionality remains intact
|
@evshank is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
kv.set()call uses{ nx: true }, which prevents updating existing records. When a key already exists in KV but the currentdiscountTypeis not inpreviousClaims, the data isn't saved - yet the API still returns asignedMessageas if the claim was successfully stored.This creates inconsistency between KV state and API response, breaking the anti-sybil protection mechanism that prevents duplicate signature issuance.
Solution
Remove
nx: truefromkv.set() options to ensure the record is always updated.Impact
discountTypeis addeddiscountTypeare still rejected (upstream logic unchanged)