Skip to content

fix: use unset-safe expansions in entrypoint validation checks #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kubudak90 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

fix: use unset-safe expansions in entrypoint validation checks #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ad1c3
fix: use unset-safe expansions in entrypoint validation checks
Mar 13, 2026
f04299f
fix: use parameter expansion for env validation with set -u
Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion geth/geth-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ GETH_CACHE_GC="${GETH_CACHE_GC:-12}"
GETH_CACHE_SNAPSHOT="${GETH_CACHE_SNAPSHOT:-24}"
GETH_CACHE_TRIE="${GETH_CACHE_TRIE:-44}"

if [[ -z "$OP_NODE_NETWORK" ]]; then
if [[ -z "${OP_NODE_NETWORK:-}" ]]; then
echo "expected OP_NODE_NETWORK to be set" 1>&2
exit 1
fi
Expand Down
4 changes: 2 additions & 2 deletions nethermind/nethermind-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ P2P_PORT="${P2P_PORT:-30303}"
ADDITIONAL_ARGS=""

# Check if required variables are set
if [[ -z "$OP_NODE_NETWORK" ]]; then
if [[ -z "${OP_NODE_NETWORK:-}" ]]; then
echo "Expected OP_NODE_NETWORK to be set" 1>&2
exit 1
fi
Expand All @@ -23,7 +23,7 @@ fi
mkdir -p "$NETHERMIND_DATA_DIR"

# Write the JWT secret
if [[ -z "$OP_NODE_L2_ENGINE_AUTH_RAW" ]]; then
if [[ -z "${OP_NODE_L2_ENGINE_AUTH_RAW:-}" ]]; then
echo "Expected OP_NODE_L2_ENGINE_AUTH_RAW to be set" 1>&2
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion op-node-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ get_public_ip() {
return 1
}

if [[ -z "$OP_NODE_NETWORK" && -z "$OP_NODE_ROLLUP_CONFIG" ]]; then
if [[ -z "${OP_NODE_NETWORK:-}" && -z "${OP_NODE_ROLLUP_CONFIG:-}" ]]; then
echo "expected OP_NODE_NETWORK to be set" 1>&2
exit 1
fi
Expand Down