fix: Security fixes for Triton HMAC key exposure and missing integrit…#5656
Open
pravali96 wants to merge 2 commits intoaws:master-v2from
Open
fix: Security fixes for Triton HMAC key exposure and missing integrit…#5656pravali96 wants to merge 2 commits intoaws:master-v2from
pravali96 wants to merge 2 commits intoaws:master-v2from
Conversation
pravali96
force-pushed
the
fix/triton-hmac-security-v2-all-bugs
branch
from
6e9283e to
8fe96c8
Compare
…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.
pravali96
force-pushed
the
fix/triton-hmac-security-v2-all-bugs
branch
from
c8d05ec to
079e1f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Security fixes for HMAC key exposure and missing integrity check in the Triton inference handler and all model server prepare paths.
Issue
Three security issues were identified in the
sagemaker-servepackage:Missing integrity check in Triton handler (CWE-502):
triton/model.pydeserializedserve.pklviacloudpickle.load()with no integrity verification before execution. A# TODOcomment at line 32 acknowledged this gap. All other handlers (TorchServe, MMS, TF Serving, SMD) already had this check.Hardcoded secret key for ONNX path (CWE-798):
model_builder_utils.pysetself.secret_key = "dummy secret key for onnx backend"in the Triton ONNX export path. This was passed asSAGEMAKER_SERVE_SECRET_KEYinto container environment variables and exposed in plaintext viaDescribeModelAPI. The ONNX path does not use pickle serialization, so no secret key is needed.HMAC secret key exposed via environment variables (CWE-200, CWE-522): All model server implementations injected the HMAC secret key as
SAGEMAKER_SERVE_SECRET_KEYinto container environment variables. These are returned in plaintext byDescribeModel,DescribeEndpointConfig, andDescribeModelPackageAPIs, allowing any principal with read permissions to extract the key and forge valid integrity signatures for malicious pickle payloads.Fix
Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed), matching the approach taken for CVE-2026-1777 (PR #5348/#5379) which made the same change for the remote function path.
Changes
check_integrity.pygenerate_secret_key()— no longer neededcompute_hash()now useshashlib.sha256()instead ofhmac.new()perform_integrity_check()no longer readsSAGEMAKER_SERVE_SECRET_KEYfrom environmentBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.