Merged
Conversation
…ix unit tests for nova model support - env_vars: append recipe/nova config to existing env_vars instead of skipping - integ test: verify both base IC and adapter IC creation for LORA models - unit tests: add _is_nova_model mock to accommodate nova model support changes
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
reviewed
Mar 15, 2026
| """ | ||
|
|
||
| min_memory_required_in_mb: int | ||
| min_memory_required_in_mb: Optional[int] = Unassigned() |
Contributor
There was a problem hiding this comment.
Can we update the engine to mark this as Optional ?
We can add a condition for this specific case
| } | ||
|
|
||
| # Nova hosting configs per model (from Rhinestone modelDeployment.ts) | ||
| _NOVA_HOSTING_CONFIGS = { |
Contributor
There was a problem hiding this comment.
Is this not available through Jumpstart ?
| def test_deploy_from_training_job(self, training_job_name, endpoint_name, cleanup_endpoints): | ||
| """Test deploying model from training job and adapter.""" | ||
| from sagemaker.core.resources import TrainingJob | ||
| """Test deploying model from training job. |
Contributor
There was a problem hiding this comment.
Can we add a test case for Nova ?
DescribeInferenceComponent returns empty ComputeResourceRequirements for adapter ICs (created with BaseInferenceComponentName), but the service model still marks MinMemoryRequiredInMb as required. Add a REQUIRED_TO_OPTIONAL_OVERRIDES config in the codegen so re-running shapes generation produces the correct Optional field.
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
previously approved these changes
Mar 18, 2026
…nder investigation
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
fixes for model builder #5625
and fixes in current PR
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.