Jackpot version 17, based on NetBeans 17

[jlahoda]

No description provided.

[mbien]

if you want, you could use the setup-java action here.

the advantage is that it is cached and the setup is really fast, you can also pick the vendor.

example:
https://github.com/actions/setup-java#install-multiple-jdks

the locations are also stored in env vars, see example above

[mbien]

would be awesome if this project would have a README in the root folder, so that github renders a short description of the project on the front page. It might be also good to mention that jackpot rules can be simply used from within NetBeans without any setup requirements.

Or it could simply link to the readme of the cmdline sub folder since that is probably the main entry point to get started I suppose.

[matthiasblaesing]

I think it would be good to squash the changes before merging. I did not see anything that makes me nervous, but I see a failure in the unittests:

    [junit] ------------- Standard Error -----------------
    [junit] Mar 13, 2023 1:16:00 PM org.netbeans.modules.settings.RecognizeInstanceObjects$MSL <clinit>
    [junit] WARNUNG: Not listening on module system
    [junit] Mar 13, 2023 1:16:31 PM org.netbeans.modules.masterfs.watcher.Watcher getNotifierForPlatform
    [junit] INFORMATION: Native file watcher is disabled
    [junit] Warnung: [options] Bootstrap Classpath nicht zusammen mit -source 8 festgelegt
    [junit] 1 Warnung
    [junit] ll=[/home/matthias/bin/jdk-19/bin/java, --add-opens=java.base/java.net=ALL-UNNAMED, --add-opens=java.desktop/sun.awt=ALL-UNNAMED, -classpath, /tmp/jackpot6990013679226371407.jar:/home/matthias/src/netbeans-jackpot30/cmdline/tool/build/test/unit/work/o.n.m.j.c.C/testRunTest/classes:/home/matthias/bin/netbeans-17/platform/modules/ext/junit-4.13.2.jar:/home/matthias/bin/netbeans-17/platform/modules/ext/hamcrest-core-1.3.jar, org.junit.runner.JUnitCore, org.netbeans.modules.jackpot30.cmdline.testtool.DoRunTests]
    [junit] JUnit version 4.13.2
    [junit] ..E
    [junit] Time: 1,589
    [junit] There was 1 failure:
    [junit] 1) /home/matthias/src/netbeans-jackpot30/cmdline/tool/build/test/unit/work/o.n.m.j.c.C/testRunTest/classes/h.test/neg(org.netbeans.modules.java.hints.declarative.test.api.DeclarativeHintsTestBase)
    [junit] junit.framework.AssertionFailedError: expected:<[package test;
    [junit] public class Test {{
    [junit]  System.err.println("a".isEmpty());
    [junit] }}
    [junit] ]> but was:<[]>
    [junit]     at junit.framework.Assert.fail(Assert.java:57)
    [junit]     at junit.framework.Assert.failNotEquals(Assert.java:329)
    [junit]     at junit.framework.Assert.assertEquals(Assert.java:78)
    [junit]     at junit.framework.Assert.assertEquals(Assert.java:86)
    [junit]     at junit.framework.TestCase.assertEquals(TestCase.java:246)
    [junit]     at org.netbeans.modules.java.hints.declarative.test.api.DeclarativeHintsTestBase.runTest(DeclarativeHintsTestBase.java:125)
    [junit]     at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77)
    [junit]     at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476)
    [junit]     at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402)
    [junit]     at org.netbeans.junit.NbTestCase.runBare(NbTestCase.java:495)
    [junit]     at junit.framework.TestResult$1.protect(TestResult.java:122)
    [junit]     at junit.framework.TestResult.runProtected(TestResult.java:142)
    [junit]     at junit.framework.TestResult.run(TestResult.java:125)
    [junit]     at junit.framework.TestCase.run(TestCase.java:130)
    [junit]     at org.netbeans.junit.NbTestCase.run(NbTestCase.java:291)
    [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:241)
    [junit]     at junit.framework.TestSuite.run(TestSuite.java:236)
    [junit]     at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
    [junit]     at org.junit.runners.Suite.runChild(Suite.java:128)
    [junit]     at org.junit.runners.Suite.runChild(Suite.java:27)
    [junit]     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
    [junit]     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
    [junit]     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
    [junit]     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
    [junit]     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
    [junit]     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
    [junit]     at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
    [junit]     at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
    [junit]     at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
    [junit]     at org.junit.runner.JUnitCore.runMain(JUnitCore.java:77)
    [junit]     at org.junit.runner.JUnitCore.main(JUnitCore.java:36)
    [junit] 
    [junit] FAILURES!!!
    [junit] Tests run: 2,  Failures: 1

[JaroslavTulach]

Great. For purposes of nbjavac I'd need to run on JDK8, but still access JDK17 APIs while refactoring. Is that possible with new version?