Switch to uv-pre-commit for lockfile management#3141
Open
kevinjqliu wants to merge 2 commits intoapache:mainfrom
Open
Switch to uv-pre-commit for lockfile management#3141kevinjqliu wants to merge 2 commits intoapache:mainfrom
kevinjqliu wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
cc @nssalian |
raulcd
reviewed
Mar 11, 2026
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks @kevinjqliu ! The pre-commit side is great but don't we still need the targets on the Makefile to update the uv lock locally to push the changes? The pre-commit hook will only validate is up-to-date but it won't update it.
nssalian
approved these changes
Mar 11, 2026
nssalian
reviewed
Mar 11, 2026
| pass_filenames: false | ||
| files: ^(pyproject\.toml|uv\.lock)$ | ||
| # Update the uv lockfile | ||
| - id: uv-lock |
Contributor
There was a problem hiding this comment.
If this updates and checks, that's great, else we might have to restore the makefile: https://docs.astral.sh/uv/guides/integration/pre-commit/ just says checks if up to date so @raulcd's comment is worth looking at by testing locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3140
Rationale for this change
This PR modernizes lockfile management by switching from custom Makefile targets and a local pre-commit hook to the official uv-pre-commit hook.
Are these changes tested?
Are there any user-facing changes?