Skip to content

chore: enforce uv lockfile consistency in CI and pre-commit #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mesejo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: enforce uv lockfile consistency in CI and pre-commit #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
enable-cache: true

- name: Install dependencies
run: uv sync --dev --no-install-package datafusion
run: uv sync --locked --dev --no-install-package datafusion
Copy link
Contributor

@kosiew kosiew Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the direction here, and the pre-commit hook looks good.

But given the PR title says this enforces lockfile consistency in CI, I think the CI side is incomplete until all uv sync calls use --locked (or the title/description is narrowed).


- name: Run Ruff
run: |
Expand Down
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,12 @@ repos:
additional_dependencies:
- tomli

- repo: https://github.com/astral-sh/uv-pre-commit
# uv version.
rev: 0.10.7
hooks:
# Update the uv lockfile
- id: uv-lock

default_language_version:
python: python3
Loading