[Fix] VMware to KVM migration instances listing failure

[nvazquez]

Description

This PR fixes instances listing from VMware vCenters for migration to KVM due to NPE on EFI settings on some VMware VMs

Fixes: #12647

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Changes tested by @rosi-achmad on #12647 (comment)

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.61%. Comparing base (c3d6a8c) to head (db0602d).
⚠️ Report is 2 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/hypervisor/vmware/mo/BaseMO.java	0.00%	1 Missing ⚠️
...com/cloud/hypervisor/vmware/util/VmwareHelper.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12766   +/-   ##
=========================================
  Coverage     17.61%   17.61%           
- Complexity    15661    15666    +5     
=========================================
  Files          5917     5917           
  Lines        531402   531402           
  Branches      64971    64971           
=========================================
+ Hits          93586    93606   +20     
+ Misses       427262   427240   -22     
- Partials      10554    10556    +2     

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	18.68% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17041

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17043

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17047

[nvazquez]

@blueorangutan test ol8 vmware-70u3

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[weizhouapache]

code lgtm

[blueorangutan]

[SF] Trillian test result (tid-15587)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55351 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12766-t15587-vmware-70u3.zip
Smoke tests completed. 145 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.12	test_list_ids_parameter.py
test_01_snapshot_root_disk	Error	49.65	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	71.76	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	71.77	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	38.50	test_snapshots.py
test_01_snapshot_usage	Error	80.80	test_usage.py
test_01_vpn_usage	Error	1.09	test_usage.py
test_03_live_migrate_VM_with_two_data_disks	Error	33.65	test_vm_life_cycle.py
test_08_migrate_vm	Error	21.93	test_vm_life_cycle.py