-
Notifications
You must be signed in to change notification settings - Fork 570
CASSPYTHON-12 Mark eventlet, gevent and Twisted event loops as deprecated #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
absurdfarce
wants to merge
4
commits into
apache:trunk
Choose a base branch
from
absurdfarce:casspython12
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−10
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
df6e89b
Add deprecated dependency and mark all relevant classes as deprecated
absurdfarce f6080d1
Updated support event loop verbiage in installation docs
absurdfarce a739756
Fix from code review: Brad noted the mismatch between supported Pytho…
absurdfarce 7bfd4f3
Code review feedback
absurdfarce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ requires = ["setuptools", "Cython>=3.0", "tomli"] | |
| name = "cassandra-driver" | ||
| description = "Apache Cassandra Python Driver" | ||
| version = "3.30.0" | ||
| dependencies = ['geomet>=1.1'] | ||
| dependencies = ['geomet>=1.1', "Deprecated>=1.3.1"] | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Worth noting that this dependency will only be present for this release. The plan is to remove the event loops in question in the next release (currently slated to be 3.31.0) and at that time deprecated can be removed as a dependency as well. |
||
| readme = "README.rst" | ||
| authors = [{name = "DataStax"}] | ||
| license = "Apache-2.0" | ||
|
|
@@ -19,11 +19,11 @@ classifiers = [ | |
| "Natural Language :: English", | ||
| "Operating System :: OS Independent", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", | ||
| "Programming Language :: Python :: Implementation :: CPython", | ||
| "Programming Language :: Python :: Implementation :: PyPy", | ||
| "Topic :: Software Development :: Libraries :: Python Modules" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this paragraph,
asyncoreis mentioned without literal formatting while other module names are consistently marked up (e.g.,asyncore/libev). For consistency and to avoid Sphinx formatting drift, wrap thisasyncoreoccurrence in double backticks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this suggestion for two reasons.
First, I prefer the idea of highlighting the first usage of a name and then leaving all other subsequent usages to be rendered as regular text.
Second (and perhaps more importantly): the second usage refers to the asyncore package in the Python runtime and not the asyncore event loop built on that package. They are two different things and using the same formatting to indicate the would confuse the issue.