Open
Conversation
- add redos/README_REDOS.md with RED OS build instructions - add redos/admc-master-1.red80.patch for RED OS 8.0 adaptation - add redos/admc-red80.spec to build RPM package - add redos/admc_build_red80.sh to automate RED OS build flow - establish initial ADMC packaging/porting baseline for RED OS 8.0
Apply patch for safe ccache destruction - Use .value(principal, nullptr) and null-check before krb5_cc_destroy in kinit() - Same in logout() to prevent crash if cache missing Closes: #TODO-krb5-null-safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a likely cause of the crash: in Krb5Client::Krb5ClientImpl::kinit, when authentication fails, krb5_cc_destroy is first called on the existing cache, but the entry in the principal_cache_map remains with the "old" (already destroyed) pointer. Then, when the correct password is entered, this invalid pointer is reused, which can cause a crash (tested on Red OS 8.0).