[Accton][as5835-54x][as5835-54t] Add set/get sfp module_reset, lpmode, tx_disable(QSFP) functi…#105
Conversation
…nality Signed-off-by: Eric Yang <eric_yang@accton.com>
eric271110
changed the title
eric271110
changed the title
| case ONLP_SFP_CONTROL_TX_DISABLE_CHANNEL: | ||
| { | ||
| if (port >= SFP_PORT_MIN && port <= SFP_PORT_MAX) { //SFP | ||
| if (onlp_file_write_int(value, MODULE_TXDISABLE_FORMAT, 3, addr, (port+1)) < 0) { |
There was a problem hiding this comment.
why do not check the present status before setting, like QSFP ?
There was a problem hiding this comment.
QSFP requires the transceiver to be present because TX disable is controlled through EEPROM access.
SFP controls TX disable via sysfs, so the transceiver doesn't necessarily need to be present.
And if we add this check, it would prevent setting TX disable when the transceiver is not present. I'm not sure whether this is desirable or not.
There was a problem hiding this comment.
If you are a end user, you have no idea about the hardware design in the box, when you try to configure all transceivers, but you get two or more different result, what do you think?
There was a problem hiding this comment.
I would find that strange. I'll add a check for module presence in the SFP case.
…e(QSFP) functionality Signed-off-by: Eric Yang <eric_yang@accton.com>
Signed-off-by: Eric Yang <eric_yang@accton.com>
eric271110
force-pushed
the
add_sfp_reset_linux_6.12
branch
from
25ff03c to
2e958d7
Compare
2 participants
Uh oh!
There was an error while loading. Please reload this page.