fix: support legacy and new dependency fields in ScanCode JSON#642
Open
kushal-p16 wants to merge 2 commits intoaboutcode-org:developfrom
Open
fix: support legacy and new dependency fields in ScanCode JSON#642kushal-p16 wants to merge 2 commits intoaboutcode-org:developfrom
kushal-p16 wants to merge 2 commits intoaboutcode-org:developfrom
Conversation
Add support for legacy ScanCode dependency field `is_resolved` alongside the newer `is_pinned` field. This ensures compatibility with both older and newer ScanCode JSON outputs without breaking existing functionality. Signed-off-by: KUSHAL P <kushalmys55@gmail.com>
fix: add backward compatibility for dependency field is_resolved - Support both `is_resolved` (legacy) and `is_pinned` (new) - Mark `is_resolved` as deprecated - Improve type documentation for clarity Signed-off-by: Kushal Prasad <your-email@example.com> Signed-off-by: KUSHAL P <kushalmys55@gmail.com>
Author
|
Hi, I’ve been working on multiple contributions recently and planning to apply for GSoC under the 5C project. Would love to get feedback or suggestions on areas I should focus on. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds backward compatibility for ScanCode dependency fields.
Changes:
is_resolvedis_pinnedThis change is non-breaking and improves robustness when handling different ScanCode versions.