Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR restores the Merkl opportunities API host used by the incentives hooks and updates the incentives symbol-to-icon mapping so GHO supply rewards render with the correct token icon.
Changes:
- Switch Merkl opportunities endpoints back to
https://api.merkl.xyzfor both Aave and Ink/tydro queries. - Add a new
IncentivesSymbolMapentry foraPlaGHOso it displays asaGHOwith the GHO icon.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/hooks/useMerklPointsIncentives.ts | Updates the hardcoded Ink/tydro Merkl API endpoint host. |
| src/hooks/useMerklIncentives.ts | Updates the hardcoded Aave Merkl API endpoint host. |
| src/components/incentives/IncentivesTooltipContent.tsx | Adds a symbol/icon mapping for aPlaGHO to fix GHO reward icon display. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const MERKL_ENDPOINT = | ||
| 'https://api-merkl.angle.money/v4/opportunities?mainProtocolId=aave&items=100&status=LIVE'; // Merkl API | ||
| 'https://api.merkl.xyz/v4/opportunities?mainProtocolId=aave&items=100&status=LIVE'; // Merkl API | ||
| const WHITELIST_ENDPOINT = 'https://apps.aavechan.com/api/aave/merkl/whitelist-token-list'; // Endpoint to fetch whitelisted tokens |
There was a problem hiding this comment.
useMerklIncentives fetches a third-party API but does not check response.ok before calling response.json(). If Merkl returns a non-2xx (rate limit, outage, HTML error page), this will throw a less actionable JSON parse error and can result in noisy retries/cached errors. Add an explicit response.ok guard and throw a descriptive error (include status / endpoint) similar to the whitelist fetch in this file.
| const MERKL_TYDRO_ENDPOINT = | ||
| 'https://api-merkl.angle.money/v4/opportunities?mainProtocolId=tydro&chainName=ink&items=100&status=LIVE'; // Merkl API | ||
| 'https://api.merkl.xyz/v4/opportunities?mainProtocolId=tydro&chainName=ink&items=100&status=LIVE'; // Merkl API | ||
|
|
There was a problem hiding this comment.
useMerklPointsIncentives does not validate the Merkl API response before parsing JSON. A non-2xx response (temporary outage / rate limit) will currently surface as an unhelpful JSON parse error. Add a response.ok check (and ideally a descriptive thrown error) before response.json() to make failures debuggable and avoid confusing UI states.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
General Changes
Add a rule to avoid displaying the APY value next to the badge
Revert to the original endpoint
Fix the logo for GHO supply rewards
Developer Notes
Add any notes here that may be helpful for reviewers.
Before:
Now:
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files