Refactor/steady state decouple from standard ga#1486
Refactor/steady state decouple from standard ga#1486francastagna wants to merge 28 commits intomasterfrom
Conversation
…ntrolDependenceGraphConfig
SteadyStateGeneticAlgorithm never called super.searchOnce() nor formTheNextPopulation(), so inheriting from StandardGeneticAlgorithm created unnecessary coupling to a concrete class. SteadyState now inherits directly from AbstractGeneticAlgorithm, simplifying the hierarchy. StandardGeneticAlgorithm no longer needs to be open.
|
Hi @francastagna , thanks. But, does this PR contain code from PR #1399? In that case, I cannot review it in this period (it is too big, and time is unfortunately limited). Not sure if @jgaleotti explained you the situation in details. Btw, regarding running experiments, my apologies, I did not understand you were waiting for me... after speaking with @jgaleotti, I have started to run them now :) |
|
Hi @arcuri82 , thanks! The large diff was my mistake... The PR was accidentally created from feature/dynamosa-3 instead of master, which pulled in all unrelated commits. The actual change is minimal: 2 files, 3 lines. I've opened a clean PR here: #1488 It's fully independent, just decouples SteadyStateGA from StandardGeneticAlgorithm in the class hierarchy. Regarding the experiments, no worries... |
2 participants
Summary
SteadyStateGeneticAlgorithmnever called any method specific toStandardGeneticAlgorithm(neithersuper.searchOnce()norformTheNextPopulation()),so the inheritance introduced unnecessary coupling to a concrete class.
SteadyStateGeneticAlgorithmnow inherits directly fromAbstractGeneticAlgorithm,simplifying the hierarchy.
StandardGeneticAlgorithmno longer needs to beopen.