Skip to content

updates required for more strict gcc13 compiler shipped with 24.04 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frank-Regal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updates required for more strict gcc13 compiler shipped with 24.04 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Timer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <iostream>
#include <assert.h>
#include <algorithm>
#include <functional>
#include "cpp_timer/Timer.h"
#include "cpp_timer/Ticker.h"
#include "cpp_timer/TimerTotal.h"
Expand Down Expand Up @@ -370,7 +371,7 @@ void Timer::buildTree_(){
// ================================================================================

const char* Timer::normalizeDuration_(time_t& duration) const{
static constexpr std::array units = {" ns", " us", " ms"};
static constexpr std::array<const char*, 3> units = {" ns", " us", " ms"};
Copy link
Collaborator

@alexnavtt alexnavtt Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a little digging and apparently this one is better fixed by adding an explicit #include <array> and then the template arguments can still be omitted

size_t div_count = 0;
while (duration > 1000 && div_count < (units.size() - 1)){
duration /= 1000;
Expand Down