Redirect profiling output from console to AKit wpilog#151
Open
nlaverdure wants to merge 1 commit intomainfrom
Open
Redirect profiling output from console to AKit wpilog#151nlaverdure wants to merge 1 commit intomainfrom
nlaverdure wants to merge 1 commit intomainfrom
Conversation
Replaces all System.out.println() calls inside PROFILING_ENABLED blocks with Logger.recordOutput() calls under the Profiling/ key hierarchy. Removes the threshold conditionals (e.g. if (totalMs > 5)) since logging every cycle is cheap and data is better analyzed graphically in AdvantageScope. Closes #146 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nlaverdure
force-pushed
the
fix/profiling-to-wpilog
branch
from
1bfb5cd to
a3af532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces every
System.out.printlninsidePROFILING_ENABLEDblocks withLogger.recordOutputcalls, making timing data available in AdvantageScope instead of the console.Affected subsystems
Robot— scheduler, game-state, and total loop timeDrive— lock, gyro update, gyro log, modules, disabled, odometry, and totalModule(×4) — updateInputs, log, rest, and totalFeeder— spindexer, kicker, spindexer log, kicker log, and totalHopper— update, log, and totalIntake— update, log, and totalLauncher— update, log, aim log, ballistics, and totalAll values are logged every cycle under the
Profiling/key hierarchy. The old threshold conditionals (e.g.if (totalMs > 5)) are removed — logging every cycle is cheap and outliers are easier to spot graphically in AdvantageScope.Closes #146