Merged
Conversation
* GetStationsByLineIdList RPCのパフォーマンス改善: コネクションプール拡大と複合インデックス追加 - max_connectionsを5から20に増加（DATABASE_MAX_CONNECTIONS環境変数で設定可能） - station_station_types (station_cd, line_group_cd, pass) の複合インデックスを追加し、NOT EXISTSサブクエリを高速化 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 主クエリを拡張してPhase 1の駅データ再取得を排除 get_by_line_id_vec_with_group_stationsを追加し、主クエリで関連する全station_g_cdの 駅を一度に取得するように変更。これによりupdate_station_vec_with_attributes内の Phase 1から駅クエリ(get_stations_by_group_id_vec_no_types)を省略し、 並列クエリを3→2に削減。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * max_connectionsの範囲チェック追加とline_id_orderの重複ID順序を修正 - DATABASE_MAX_CONNECTIONSに範囲チェック(1..=1000)を追加し、範囲外やパース失敗時はwarnログ付きでデフォルト値にフォールバック - line_id_orderの構築で重複line_idがある場合に最初の出現順を保持するよう修正（SQL CASE WHENと同等の挙動） Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.