Skip to content

Fix for issue 1463#1466

Merged
brcekadam merged 1 commit intoTeamCOMPAS:devfrom
brcekadam:fix_claeys_prescription
Mar 15, 2026
Merged

Fix for issue 1463#1466
brcekadam merged 1 commit intoTeamCOMPAS:devfrom
brcekadam:fix_claeys_prescription

Conversation

@brcekadam
Copy link
Collaborator

Fixes a typo from Claeys+2014 common-envelope lambda prescription. This sign error is mentioned in e.g. Appendix E.1 from Marchant+2021.

Closes #1463

@brcekadam brcekadam self-assigned this Mar 15, 2026
@brcekadam brcekadam added the bug Something isn't working label Mar 15, 2026
Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thank you, @brcekadam !

Copy link
Collaborator

@jeffriley jeffriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @brcekadam

Oh - @ilyamandel beat me to it :-)

@brcekadam brcekadam merged commit a4b538d into TeamCOMPAS:dev Mar 15, 2026
2 of 3 checks passed
@brcekadam brcekadam deleted the fix_claeys_prescription branch March 15, 2026 23:47
@ilyamandel
Copy link
Collaborator

@avivajpeyi -- note that the CI seems to be failing again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LAMBDA_DEWI (Claeys+2014) produce negative common envelope λ in CHeB and EAGB stars

3 participants