Fix quad-base with custom names#413
Merged
chrishalcrow merged 1 commit intoSpikeInterface:mainfrom Mar 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to deal with Quad Base when a custom name is used.
There are 3 different cases:
(handled) The custom probe name corresponds to the serial number. In this case, the probe is assigned a name based on the stream name, which already containes the "-{shank_id}" suffix to identify the shank. (e.g. this probe)
(handled) The custom probe name DOES NOT correspond to the serial number, but the shank id is part of the name, so the probe is unambiguously selected (e.g., this probe)
(handled by this PR) The custom name DOES NOT correspond to the serial number and it DOES NOT have the shank id in its name. In this case (before this PR), multiple probes with the same name were generated, so the wrong probe could have been selected. This PR fixes it by appending the shank id from the probe attribute to the name (e.g., this probe)
The fix is simply this:
Also updated tests to check that the correct shank is loaded using the contact x positions!