Open
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Coverage report
Test suite run success3924 tests passing in 1510 suites. Report generated by 🧪jest coverage report action from 07d4304 |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/cli-launcher.d.ts@@ -3,7 +3,7 @@ interface Options {
argv?: string[];
}
/**
- * Launches the CLI through our custom OCLIF loader.
+ * Launches the CLI.
*
* @param options - Options.
* @returns A promise that resolves when the CLI has been launched.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Hydrogen PR Shopify/hydrogen#3531 (merged March 19, 2026) moved the Hydrogen monorepo dev workflow into the Hydrogen repo via self-contained patch scripts (
scripts/patch-cli.mjs / scripts/unpatch-cli.mjs). This makescustom-oclif-loader.tsobsolete.WHAT is this pull request doing?
Deletes , the now obsolete,
custom-oclif-loader.tsand replacesShopifyConfigwith oclif'sConfigdirectly incli-launcher.ts.How to test your changes?
cd packages/cli-kit && pnpm buildcd packages/cli-kit && pnpm vitest runAlso, create a symlink to the build
cli/run.jsand smoked test:Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist