Skip to content

feat: remove custom-oclif-loader#7068

Open
andguy95 wants to merge 2 commits intomainfrom
an-remove-custom-oclif-loader
Open

feat: remove custom-oclif-loader#7068
andguy95 wants to merge 2 commits intomainfrom
an-remove-custom-oclif-loader

Conversation

@andguy95
Copy link
Contributor

WHY are these changes introduced?

Hydrogen PR Shopify/hydrogen#3531 (merged March 19, 2026) moved the Hydrogen monorepo dev workflow into the Hydrogen repo via self-contained patch scripts (scripts/patch-cli.mjs / scripts/unpatch-cli.mjs). This makes custom-oclif-loader.ts obsolete.

  1. Local Hydrogen testing — now handled by Hydrogen's own patch system
  2. Older Hydrogen version override — never worked for regular users (gated behind isDevelopment())

WHAT is this pull request doing?

Deletes , the now obsolete, custom-oclif-loader.ts and replaces ShopifyConfig with oclif's Config directly in cli-launcher.ts.

How to test your changes?

  • Build the package: cd packages/cli-kit && pnpm build
  • cli-kit test suite: cd packages/cli-kit && pnpm vitest run

Also, create a symlink to the build cli/run.js and smoked test:

#!/usr/bin/env node

process.env.SHOPIFY_RUBY_BINDIR = "/opt/rubies/3.1.2/bin"
process.env.SHOPIFY_HOMEBREW_FORMULA = "shopify-cli"

import("$HOME/src/github.com/Shopify/cli/packages/cli/bin/run.js")

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@andguy95 andguy95 requested a review from a team as a code owner March 20, 2026 19:41
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 82.3% 14970/18190
🟡 Branches 74.87% 7402/9886
🟢 Functions 81.25% 3779/4651
🟢 Lines 82.71% 14157/17116

Test suite run success

3924 tests passing in 1510 suites.

Report generated by 🧪jest coverage report action from 07d4304

@andguy95 andguy95 requested a review from a team as a code owner March 20, 2026 19:49
@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/cli-launcher.d.ts
@@ -3,7 +3,7 @@ interface Options {
     argv?: string[];
 }
 /**
- * Launches the CLI through our custom OCLIF loader.
+ * Launches the CLI.
  *
  * @param options - Options.
  * @returns A promise that resolves when the CLI has been launched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant