Fix area visualizer breaking after stop/start cycle#258
Closed
Copilot wants to merge 2 commits intorefactor/visualizerfrom
Closed
Fix area visualizer breaking after stop/start cycle#258Copilot wants to merge 2 commits intorefactor/visualizerfrom
Copilot wants to merge 2 commits intorefactor/visualizerfrom
Conversation
…sualizerAreaImpl Co-authored-by: twisti-dev <76837088+twisti-dev@users.noreply.github.com> Agent-Logs-Url: https://github.com/SLNE-Development/surf-api/sessions/a087fbec-b95d-49bd-aec5-8fb163cb2aff
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on visualizer state management and concurrency handling
Fix area visualizer breaking after stop/start cycle
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stopVisualizing()was cancelling all child jobs inscope, including the long-livedconsumeEachworker that drainscomputationChannel. SincestartVisualizing()is delegated and never recreates the worker, any settings/corner mutations after the first stop/start cycle silently enqueued to a dead channel.Changes
private val workerJob: Jobholds theconsumeEachcoroutine launched ininitstopVisualizing()— only cancels non-worker scope children:recompute()against stale execution — added!isVisualizing()early-returns after each suspension point to prevent an in-flight recompute from spawning entities after the visualizer has been stopped⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.