Skip to content

add gated SCEvents components#2050

Merged
codebyemily merged 6 commits intodevfrom
emily/scevents-tab
Mar 21, 2026
Merged

add gated SCEvents components#2050
codebyemily merged 6 commits intodevfrom
emily/scevents-tab

Conversation

@codebyemily
Copy link
Contributor

@codebyemily codebyemily commented Mar 18, 2026

resolves #2051

SCEvents not enabled
Screenshot 2026-03-20 at 7 34 49 PM

SCEvents enabled:
Screenshot 2026-03-20 at 7 40 52 PM

Screenshot 2026-03-20 at 7 41 10 PM Screenshot 2026-03-20 at 9 12 10 PM

Copy link
Collaborator

@steeevin88 steeevin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, could you include screenshots in the PR description if possible? just so as a reviewer I know it works 😅

@steeevin88 steeevin88 requested a review from adarshm11 March 21, 2026 01:50
@codebyemily codebyemily changed the title added events page to navbar add gated SCEvents components Mar 21, 2026
Copy link
Contributor

@adarshm11 adarshm11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done fine but i would recommend mimicking how cleezy does it here. in that case people can run cleezy locally and set ENABLED: true in config.json. i assume that this page will eventually have an api side on clark too, and whether or not it's enabled on frontend will be determined something like:

page loads -> useEffect queries api route for loading events -> api reads config.json for enabled value -> returns to frontend either data or enabled = false.

this seems like a good pattern for scevents to follow too, once the api side is built out on Clark

@steeevin88
Copy link
Collaborator

this is done fine but i would recommend mimicking how cleezy does it here. in that case people can run cleezy locally and set ENABLED: true in config.json. i assume that this page will eventually have an api side on clark too, and whether or not it's enabled on frontend will be determined something like:

page loads -> useEffect queries api route for loading events -> api reads config.json for enabled value -> returns to frontend either data or enabled = false.

this seems like a good pattern for scevents to follow too, once the api side is built out on Clark

makes sense + yeah we'll keep this in mind as we build out more stuff on the Clark side

@codebyemily codebyemily merged commit a86fc6f into dev Mar 21, 2026
4 checks passed
@codebyemily codebyemily deleted the emily/scevents-tab branch March 21, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature gate SCEvents components throughout Clark

3 participants