Conversation
PR ReviewThis is a focused documentation update. Changes are clean and improve the developer experience. A few observations below. docs/audiences.md — Positive: Adding the explicit Step 3 (Create and Assign a Job) section is a good fix — the previous structure jumped from adding qualification examples to the full complete example, leaving a gap in the step-by-step flow. Expanding the qualification examples from 3 to 8 datapoints is more realistic and gives readers a better sense of how many examples are typically needed. Using flux_book/mj_book consistently in both the step-by-step job definition and the complete example is correct; the previous version used flux_flower in the complete example but flower is now one of the qualification examples. docs/audiences.md — Minor: In the complete example, the inline comments '# Preview before running' and '# Assign to audience and get results' were removed. For new users, those comments were helpful signposts. Consider keeping them or replacing with a brief prose sentence above the block. docs/flows.md — Positive: Clarifying that flows are independent from each other and introducing the TTL/threshold concepts is a meaningful addition for users who want fine-grained control. docs/flows.md — Suggestions:
uv.lock: The lock file shows a version bump from 3.5.4 to 3.5.5 for the rapidata package, which implies a corresponding pyproject.toml change. That change does not appear in the diff — please confirm it was already committed or is included elsewhere so the lock file stays in sync. Overall this is a solid, low-risk documentation improvement. The Step 3 addition in audiences.md is the most impactful change and addresses a real gap in the guide. |
No description provided.