Skip to content

only accept UUID packet during state 1 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hakusaro merged 1 commit into from
Mar 11, 2026
Merged

only accept UUID packet during state 1 #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions TerrariaServerAPI/TerrariaApi.Server/HookManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,14 @@ internal bool InvokeNetGetData(ref byte msgId, MessageBuffer buffer, ref int ind
//We copy the bytes of the UUID then convert it to string. Then validating the GUID so its the correct format.
//Then the bytes get hashed, and set as ClientUUID (and gets written in DB for auto-login)
//length minus 2 = 36, the length of a UUID.
//We only accept this packet during the initial connectioon state (1), and only if their current UUID is blank,
//to prevent malicious clients from changing their UUID after connecting.
case PacketTypes.ClientUUID:
if ((Netplay.Clients[buffer.whoAmI].State != 1 || !string.IsNullOrEmpty(Netplay.Clients[buffer.whoAmI].ClientUUID)))
{
return true;
}

if (length == 38)
{
byte[] uuid = new byte[length - 2];
Expand Down
Loading