Skip to content

Optimise LINQ queries #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bergmeister wants to merge 5 commits into
base: main
Choose a base branch
from
+7 −7
Open

Optimise LINQ queries #2160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6f0b3e
Initial plan
Copilot Feb 17, 2026
a02b5bb
Optimize LINQ operations for better performance
Copilot Feb 17, 2026
5275279
Merge branch 'main' into copilot/find-optimisations
bergmeister Mar 6, 2026
2ccec00
Update Rules/AvoidMultipleTypeAttributes.cs
bergmeister Mar 6, 2026
3214bc3
Update Rules/AvoidMultipleTypeAttributes.cs
bergmeister Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Engine/Generic/RuleSuppression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ public static List<RuleSuppression> GetSuppressions(IEnumerable<AttributeAst> at

if (targetAsts != null)
{
if (targetAsts.Count() == 0)
if (!targetAsts.Any())
{
if (String.IsNullOrWhiteSpace(scopeAst.Extent.File))
{
Expand Down
8 changes: 4 additions & 4 deletions Engine/ScriptAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,9 @@ internal bool ParseProfile(object profileObject, PathIntrinsics path, IOutputWri
return false;
}

this.severity = (severityList.Count() == 0) ? null : severityList.ToArray();
this.includeRule = (includeRuleList.Count() == 0) ? null : includeRuleList.ToArray();
this.excludeRule = (excludeRuleList.Count() == 0) ? null : excludeRuleList.ToArray();
this.severity = (severityList.Count == 0) ? null : severityList.ToArray();
this.includeRule = (includeRuleList.Count == 0) ? null : includeRuleList.ToArray();
this.excludeRule = (excludeRuleList.Count == 0) ? null : excludeRuleList.ToArray();
if (settings != null
&& settings.ContainsKey("Rules"))
{
Expand Down Expand Up @@ -609,7 +609,7 @@ private bool ParseProfileString(string profile, PathIntrinsics path, IOutputWrit
IEnumerable<Ast> hashTableAsts = profileAst.FindAll(item => item is HashtableAst, false);

// no hashtable, raise warning
if (hashTableAsts.Count() == 0)
if (!hashTableAsts.Any())
{
writer.WriteError(new ErrorRecord(new ArgumentException(string.Format(CultureInfo.CurrentCulture, Strings.InvalidProfile, profile)),
Strings.ConfigurationFileHasNoHashTable, ErrorCategory.ResourceUnavailable, profile));
Expand Down
2 changes: 1 addition & 1 deletion Engine/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ private void parseSettingsFile(string settingsFilePath)
IEnumerable<Ast> hashTableAsts = profileAst.FindAll(item => item is HashtableAst, false);

// no hashtable, raise warning
if (hashTableAsts.Count() == 0)
if (!hashTableAsts.Any())
{
throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, Strings.InvalidProfile, settingsFilePath));
}
Expand Down
2 changes: 1 addition & 1 deletion Rules/AvoidMultipleTypeAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
// Iterates all ParamAsts and check the number of its types.
foreach (ParameterAst paramAst in paramAsts)
{
if (paramAst.Attributes.Where(typeAst => typeAst is TypeConstraintAst).Count() > 1)
if (paramAst.Attributes.OfType<TypeConstraintAst>().Skip(1).Any())
{
yield return new DiagnosticRecord(
String.Format(CultureInfo.CurrentCulture, Strings.AvoidMultipleTypeAttributesError, paramAst.Name),
Expand Down