Skip to content

Improved JacobiTransformation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordanmontt merged 1 commit into from
Mar 18, 2026
Merged

Improved JacobiTransformation #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Math-Matrix-Tests/PMJacobiTransformationTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ PMJacobiTransformationTest >> testEigenvalueOfIdentityMatrixIsOne [
jacobiTransformation := PMJacobiTransformation matrix: identityMatrix.

expected := #(1 1).
self assert: jacobiTransformation evaluate equals: expected
self assert: jacobiTransformation eigenValues equals: expected
]

{ #category : 'tests' }
Expand All @@ -26,7 +26,7 @@ PMJacobiTransformationTest >> testEigenvectorsOfIdentityMatrixAreTheUnitVectors
identityMatrix := PMMatrix rows: #(#(1 0) #(0 1)).
jacobiTransform := PMJacobiTransformation matrix: identityMatrix.

matrixOfEigenvectors := jacobiTransform transform.
matrixOfEigenvectors := jacobiTransform eigenVectors.

expected := PMSymmetricMatrix identity: 2.
self assert: matrixOfEigenvectors equals: expected.
Expand Down
3 changes: 1 addition & 2 deletions src/Math-Matrix-Tests/PMMatrixTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,8 @@ PMMatrixTest >> testEigenvalues [
expectedEigenvalues := #(8.105482616526306 4.776537928330764 2.1179794551429305).

finder := PMJacobiTransformation matrix: matrix.
finder desiredPrecision: 1.0e-09.

eigenvalues := finder evaluate.
eigenvalues := finder eigenValues.

eigenvalues with: expectedEigenvalues do: [ :actual :expected |
self assert: actual closeTo: expected ].
Expand Down
2 changes: 1 addition & 1 deletion src/Math-Matrix-Tests/PMSingularValueDecompositionTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ PMSingularValueDecompositionTest class >> loadExamples [
example4 := PMSingularValueDecompositionExample
newMatrix: (PMMatrix rows: #( #( 1 0 0 0 2 ) #( 0 0 3 0 0 ) #( 0 0 0 0 0 ) #( 0 2 0 0 0 ) ))
u: (PMMatrix rows: #( #( 0 1 0 0 ) #( 1 0 0 0 ) #( 0 0 0 1 ) #( 0 0 1 0 ) ))
v: (PMMatrix rows: { { 0. 0.2 sqrt. 0. 0.8 sqrt. 0 }. { 0. 0. 1. 0. 0 }. { 1. 0. 0. 0. 0 }. { 0. 0. 0. 0. 1 }. { 0. 0.8 sqrt. 0. 0.2 sqrt negated. 0 } })
v: (PMMatrix rows: { { 0. 0.2 sqrt. 0. 0. 0.8 sqrt }. { 0. 0. 1. 0. 0 }. { 1. 0. 0. 0. 0 }. { 0. 0. 0. 1. 0 }. { 0. 0.8 sqrt. 0. 0. 0.2 sqrt negated } })
s: (PMMatrix rows: { { 3. 0. 0. 0. 0 }. { 0. 5 sqrt. 0. 0. 0 }. { 0. 0. 2. 0. 0 }. { 0. 0. 0. 0. 0 } }).
]

Expand Down
Loading
Loading