Open
Conversation
Mysticial
reviewed
Mar 20, 2026
| throw InternalProgramError(nullptr, PA_CURRENT_FUNCTION, "Onnx API returned a null pointer."); | ||
| } | ||
|
|
||
| // Bit redundant now, but still might be useful to add logging or other init? |
Collaborator
There was a problem hiding this comment.
This was a real error we hit a while back when there was a version mismatch between what we built against vs. the shared lib.
Author
There was a problem hiding this comment.
split it off into another pr #1139 and allowed that check when using ONNX Runtime < 1.24.0
Collaborator
|
This also looks good so far! @Koi-3088 has some comments about the resource paths which seems undecided right now. Feel free to split the gstreamer and ONNX change into a separate PR. Those are trivial and can go right in. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64
Fixes the flickering by defaulting to gstreamer instead of ffmpeg for the backend for Qt multimedia
There is still an occasional slight flickering in the capture card's brightness, however it doesn't seem to stop a program from being able to run effectively and might be related to a bug in Qt. I have tested it briefly with Qt6.11.0 and it didn't appear.