Conversation
jemarq04
approved these changes
Mar 13, 2026
Contributor
jemarq04
left a comment
jemarq04
left a comment
There was a problem hiding this comment.
Ah, I hadn't noticed that with the timezone! Good catch!
Member
Author
|
Yeah, I noticed that the timezone changes between PR and push jobs in CircleCI. That's crazy :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the meta endpoint exposes a deploy date in the ISO 8601 format, apparently this format (interpreted by
git) gives a different date format depending on the timezone, if the timezone is +0 the date is2026-03-13T10:51:29Zwhile in a +1 timezone the output date is2026-03-13T12:14:51+01:00. These dates lenght different and tests fail.It's better to use the Unix timestamp since our API is primarily machine-readable. And we don't care about the timezone.