Skip to content

Reject port names containing whitespace#18

Open
L4co77 wants to merge 1 commit intomainfrom
port-name-whitespace-validation
Open

Reject port names containing whitespace#18
L4co77 wants to merge 1 commit intomainfrom
port-name-whitespace-validation

Conversation

@L4co77
Copy link

@L4co77 L4co77 commented Mar 19, 2026

  • Add std::isspace check to IsAllowedPortName() to reject port names containing whitespace
  • Add IsAllowedPortName() validation in loadSubtreeModel() for TreeNodesModel port names, which previously had no validation
  • Update CreatePort error message to mention the whitespace constraint
  • Add tests for whitespace rejection in port names

@L4co77 L4co77 requested a review from dsobek March 19, 2026 10:45
@L4co77 L4co77 self-assigned this Mar 19, 2026
@L4co77 L4co77 force-pushed the port-name-whitespace-validation branch from 6bf9c7a to a96649c Compare March 19, 2026 10:47
Copy link
Collaborator

@dsobek dsobek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just going to give this a test in against MoveIt Pro before approving.

For the forward port, could you evaluate if it makes sense to merge the upstream of behaviortree.cpp into our fork? In particular, I realized that some of the validation logic I pointed to you exists in the upstream master branch, and so there might be some duplicate work there. I created a separate issue for this https://github.com/PickNikRobotics/moveit_pro/issues/17640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants