Draft
Conversation
* Introduced `ServiceControl.Transports.IBMMQ` with necessary configurations, transport customization, and manifest file. * Added `ServiceControl.Transports.IBMMQ.Tests` to verify IBM MQ transport functionality. * Updated `ServiceControl.slnx`, `nuget.config`, and `Directory.Packages.props` to include IBM MQ dependencies and projects.
Replace NoOpQueueLengthProvider with a real implementation that connects to the queue manager and queries CurrentDepth via MQOO_INQUIRE. Connection properties are parsed from the MQ URI connection string, matching the same format used by the transport manifest sample.
Resolve breaking API renames: namespace IbmMq → IBMMQ, types IbmMqTransport → IBMMQTransport, IbmMqTransportOptions → IBMMQTransportOptions.
- Add IBMMQ to test matrix (Linux only) - Add IncludeInIBMMQTestsAttribute and TestsFilter for test filtering - Pass connection string via env block on run-tests step - Unify TestConnectionDetails to read ServiceControl_TransportTests_IBMMQ_ConnectionString
- Fix csproj artifact destination from Transports\MSMQ to Transports\IBMMQ - Remove Windows-only condition (was copy-pasted from MSMQ) - Add IBMMQ to TransportNames and packaging approval files
Extract shared connection URI parsing into ConnectionProperties helper and implement DLQ depth check using MQQueueManager.DeadLetterQueueName. Also remove unused MSMQ-era package references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.