Merged
Conversation
In testing ICON datasets, some do not have the `location` or `mesh` attributes defined in the generated uxarray datasets. Initially, I was thinking these attributes would be used for selecting default interpolation methods and would therefor be required. However, we've implemented interpolation method selection based of the combination of vertical and lateral dimension names and requiring these attributes is no longer necessary This is related to Parcels-code/parcels-benchmarks#38
VeckoTheGecko
approved these changes
Mar 17, 2026
erikvansebille
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In testing ICON datasets, some do not have the
locationormeshattributes defined in the generated uxarray datasets. Initially, I was thinking these attributes would be used for selecting default interpolation methods and would therefor be required. However, we've implemented interpolation method selection based of the combination of vertical and lateral dimension names and requiring these attributes is no longer necessaryThis is related to Parcels-code/parcels-benchmarks#38