Skip to content

Feature/upload input v3 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 6 commits into from
Mar 23, 2026
Merged

Feature/upload input v3 #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06cbcb4
feat: build upload input v3 and tests
santipalenque Mar 11, 2026
f9ff351
feat: new mui version of upload input V3
santipalenque Mar 12, 2026
f948cfa
v4.2.25-beta.1
santipalenque Mar 12, 2026
79ff728
fix: copilot feedback
santipalenque Mar 12, 2026
c9cd278
fix: few tweaks
santipalenque Mar 18, 2026
90f945e
v4.2.25-beta.2
santipalenque Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "openstack-uicore-foundation",
"version": "4.2.24",
"version": "4.2.25-beta.2",
"description": "ui reactjs components for openstack marketing site",
"main": "lib/openstack-uicore-foundation.js",
"scripts": {
Expand All @@ -22,6 +22,7 @@
"@babel/runtime": "^7.20.7",
"@emotion/react": "^11.11.4",
"@emotion/styled": "^11.11.5",
"@mui/icons-material": "^7.3.9",
Copy link

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

What is the latest version of @mui/icons-materialand is it compatible with@mui/material 5.15.20?

💡 Result:

  • Latest @mui/icons-material: v7.3.9. (intel.aikido.dev)
  • Compatible with @mui/material@5.15.20? No. Recent @mui/icons-material releases track @mui/material as a peer dependency on the same major line (e.g., v7 icons peer on @mui/material v7). (github.com)
  • What to use with @mui/material@5.15.20: install @mui/icons-material@5.15.20 (or another 5.15.x) to match. (newreleases.io)

Citations:

Fix @mui/icons-material version mismatch between devDependencies and peerDependencies.

The devDependency specifies ^7.3.9 but the peerDependency specifies ^5.15.20, and @mui/icons-material@7 is incompatible with @mui/material@5.15.20. Update the devDependency to ^5.15.20 to match @mui/material.

Proposed fix 
-    "@mui/icons-material": "^7.3.9",
+    "@mui/icons-material": "^5.15.20",

Also applies to: 109-109

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 25, DevDependency for `@mui/icons-material` is pinned to
^7.3.9 while peerDependencies expect ^5.15.20 (incompatible with
`@mui/material`@5.15.20); update the devDependency entry for "@mui/icons-material"
to ^5.15.20 so devDependencies and peerDependencies match the installed
`@mui/material` major version, and run install/update lockfile accordingly (verify
package.json devDependencies and peerDependencies entries for
"@mui/icons-material" and "@mui/material" for consistency).

"@mui/material": "^5.15.20",
"@react-pdf/renderer": "^3.1.11",
"awesome-bootstrap-checkbox": "^1.0.1",
Expand Down Expand Up @@ -105,6 +106,7 @@
"peerDependencies": {
"@emotion/react": "^11.11.4",
"@emotion/styled": "^11.11.5",
"@mui/icons-material": "^5.15.20",
"@mui/material": "^5.15.20",
"@react-pdf/renderer": "^3.1.11",
"awesome-bootstrap-checkbox": "^1.0.1",
Expand Down
1 change: 1 addition & 0 deletions src/components/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export {default as DateTimePicker} from './inputs/datetimepicker'
export {default as GroupedDropdown} from './inputs/grouped-dropdown'
export {default as UploadInput} from './inputs/upload-input'
export {default as UploadInputV2} from './inputs/upload-input-v2'
export {default as UploadInputV3} from './inputs/upload-input-v3'
export {default as CompanyInput} from './inputs/company-input'
export {default as PromocodeInput} from './inputs/promocode-input'
export {default as SponsorInput} from './inputs/sponsor-input'
Expand Down
0 ...components/inputs/upload-input-v2/icon.js → src/components/inputs/dropzone/icon.js
View file
Open in desktop
File renamed without changes.
0 ...onents/inputs/upload-input-v2/dropzone.js → src/components/inputs/dropzone/index.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/components/inputs/upload-input-v2/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
**/

import React from 'react'
import DropzoneJS from './dropzone'
import DropzoneJS from '../dropzone'
import './index.less';
import file_icon from '../upload-input/file.png';
import ProgressiveImg from "../../progressive-img";
Expand Down
Loading
Loading