Improve comparison coverage, reporting, and HTML diff page#20
Merged
AnHeuermann merged 1 commit intomainfrom Mar 13, 2026
Merged
Improve comparison coverage, reporting, and HTML diff page#20AnHeuermann merged 1 commit intomainfrom
AnHeuermann merged 1 commit intomainfrom
Conversation
- Expand variable matching to include MTK observed (algebraically
eliminated) variables via sol(t; idxs=sym), raising coverage beyond
state variables alone
- Track skipped signals (reference vars not found in simulation) and
surface them in a new cmp_skip field on ModelResult
- Add variable-coverage table to _diff.html listing every reference
signal as pass/fail/not-found; move table above the charts
- Colour index.html "Ref Cmp" cells orange (partial) when all compared
signals pass but some reference variables were not found
- Always link the sim CSV from the "Ref Cmp" cell; show "(CSV N/A)"
when the file was skipped for exceeding CSV_MAX_SIZE_MB
- Fix time-column lookup in reference CSVs to be case-insensitive
("Time" vs "time"), fixing missing comparisons for some models
- Replace fixed meta placeholders in diff_template.html with a single
META_BLOCK substitution; guard JS against empty CSV data
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes