Skip sim CSVs exceeding a configurable size limit#19
Merged
AnHeuermann merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
Member
Author
|
TODO: Generate the diff CSV files even if the CSV itself is too large to upload to GitHub. |
Add CSV_MAX_SIZE_MB constant (default 20 MB) and a csv_max_size_mb keyword argument threaded through main → test_model → run_simulate and generate_report → _cmp_cell. When a sim CSV exceeds the limit a .toobig marker file is written alongside it; the report shows "(CSV N/A)" for those models. The CSV is kept on disk for local inspection but excluded from the gh-pages upload via an rsync exclude list generated from the .toobig markers. Also removes a stray @show debug line from _bm_sha. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AnHeuermann
force-pushed
the
commit-less
branch
from
723f3f1 to
3fa3a87
Compare
Member
Author
|
The HTML is looking good: Hard to test how the upload on git is working. Let's merge and try it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Simulation result CSVs can exceed GitHub's 100 MB file size limit, preventing pushes to gh-pages. Fix by checking the CSV size after writing and, if it exceeds the limit (default 20 MB), deleting the file and leaving a _sim.csv.toobig marker in its place.
The HTML report detects the marker and shows "(CSV N/A)" with a tooltip instead of a download link. The limit is exposed as a
csv_max_size_mbkeyword argument onmain(),test_model(),run_simulate(), andgenerate_report(), defaulting to the module-level constantCSV_MAX_SIZE_MB = 20.