Improve reporting of "fn is not a function" error#1317
Merged
josephjclark merged 3 commits intomainfrom Mar 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
This PR reports a better error for the extremely frustrating "fn is not a function" error that creeps up when running a job like:
Fixes #811
Implementation Details
The problem occurs when the operations array that gets passed to the core execute reducer includes a non-function value.
When doing
console.log()at the top level, we compile like this:Obviously console.log returns undefined, so this may as well be:
Which is an error in the runtime.
The validation catches this case and (hopefully!) returns a clearer error message - although of course this is a hard thing to explain, and it's hard to generate an error position at this point, so I have to be a bit vague.
QA Notes
Output in CLI:
Output in Worker:
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy