fix: remove pkg_resources fallback for setuptools 82+ compatibility#1466
Open
junagent wants to merge 4 commits intoNVIDIA:masterfrom
Open
fix: remove pkg_resources fallback for setuptools 82+ compatibility#1466junagent wants to merge 4 commits intoNVIDIA:masterfrom
junagent wants to merge 4 commits intoNVIDIA:masterfrom
Conversation
Author
|
Bug label request for bounty tracking on Algora/IssueHunt. This PR removes deprecated pkg_resources fallback code for setuptools 82+ (PEP 740, Feb 2026) compatibility. The else branch using pkg_resources is dead code for Python 3.8+ and will fail on setuptools 82+. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated
pkg_resourcesfallback code for Python < 3.8 compatibility.Root Cause
The code used a version check to conditionally import from
importlib.metadata(Python 3.8+) or fall back topkg_resources(removed in setuptools 82, PEP 740, Feb 2026):The
elsebranch usingpkg_resourcesis dead code for Python 3.8+ and will fail on setuptools 82+.Fix
Remove the
elsebranch and useimportlib.metadata.version()directly. Since Python 3.8 is the minimum supported version, thesys.versioncheck is redundant.Files Changed
triton/deployment_toolkit/triton_performance_runner/model_analyzer/runner.pytriton/deployment_toolkit/triton_performance_runner/perf_analyzer/runner.pyTools/PyTorch/TimeSeriesPredictionPlatform/triton/run_performance_on_triton.pyPyTorch/Forecasting/TFT/triton/run_performance_on_triton.pyFixes #ISSUE