chore: extends digest service and ctrl to accept the perps asset ticker#8182
Open
chore: extends digest service and ctrl to accept the perps asset ticker#8182
Conversation
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Extends
AiDigestService.searchDigestandAiDigestController.fetchMarketInsightsto accept any string identifier rather than only CAIP-19 asset types. The CAIP-19 IDs continue to use thecaipAssetTypequery parameter, while all other strings (perps market symbols like ETH) automatically use the newhlPerpsMarketquery parameter introduced by the backend. This avoids the need for a separate method.References
Checklist
Note
Medium Risk
Changes the
searchDigestrequest semantics and controller validation, which may affect consumers expecting CAIP-19-only inputs and could alter cache keys/state shape for persisted data. Risk is limited to AI digest fetching/caching behavior and associated API calls.Overview
Extends market-insights digest lookup to accept either CAIP-19 asset types or arbitrary identifiers (e.g. perps symbols like
ETH).AiDigestService.searchDigestnow auto-selects the backend query param (caipAssetTypevs newhlPerpsMarket) based onisCaipAssetType, andAiDigestController.fetchMarketInsightsdrops strict CAIP-19 validation in favor of rejecting only empty identifiers.Renames the cached entry field/param from
caip19IdtoassetIdentifier, updates the error constant toINVALID_ASSET_IDENTIFIER, and adds/adjusts tests to cover perps URL encoding and independent caching for CAIP-19 vs perps identifiers.Written by Cursor Bugbot for commit 566b7c6. This will update automatically on new commits. Configure here.