Merged
Conversation
Updatetest script fails due to incorrect relative path, which was changed during cli esm migration. Fix the relative path so the script works.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2877 +/- ##
=======================================
Coverage 71.04% 71.04%
=======================================
Files 131 131
Lines 7117 7117
Branches 1586 1613 +27
=======================================
Hits 5056 5056
Misses 1961 1961
Partials 100 100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yihao03 Each PR must have a SEMVER impact label, please remember to label the PR properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updatetest script fails due to incorrect
relative path, which was changed during
cli esm migration.
Fix the relative path so the script works.
What is the purpose of this pull request?
Fix updatetest script
Overview of changes:
Updates the relative path of the updatetest script so that it points to the legitimate file.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Fix updatetest script
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):